New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Routing] Fix resource miss #24642

Closed
wants to merge 2 commits into
base: 2.8
from

Conversation

Projects
None yet
6 participants
@dunglas
Member

dunglas commented Oct 20, 2017

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Some routing resources are not watched. To reproduce:

  1. Install Symfony 4
  2. Change something in config/routes.yaml

The change is not taken into account.

This PR fixes this bug.

@nicolas-grekas nicolas-grekas added this to the 2.8 milestone Oct 20, 2017

@fabpot

fabpot approved these changes Oct 20, 2017

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Oct 20, 2017

Member

Thank you @dunglas.

Member

fabpot commented Oct 20, 2017

Thank you @dunglas.

fabpot added a commit that referenced this pull request Oct 20, 2017

bug #24642 [Routing] Fix resource miss (dunglas)
This PR was squashed before being merged into the 2.8 branch (closes #24642).

Discussion
----------

[Routing] Fix resource miss

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Some routing resources are not watched. To reproduce:

1. Install Symfony 4
2. Change something in `config/routes.yaml`

The change is not taken into account.

This PR fixes this bug.

Commits
-------

6610c25 [Routing] Fix resource miss

@fabpot fabpot closed this Oct 20, 2017

This was referenced Oct 30, 2017

This was referenced Nov 10, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment