Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.Sign up
[Workflow] Introduce a Workflow interface #24751
referenced this pull request
Nov 4, 2017
nice work :) i also asked @nicolas-grekas if this is really the desired upgrade path.
Basically i see one other option; to make
Registry final since 3.4, so we can keep favoring
add(); meaning less upgrade hassle for users as the common usecase would keep working, given
Workflow implements WorkflowInterface tomorrow.
Also means we close extensibility on
Registry, which we can open by introducing a
RegistryInterface, when needed.
WDYT of @ro0NL's path ?
It's not too late to say that Registry is final since 3.4 @nicolas-grekas ?
I guess it could be a thing too to be able to re-implement the registry, and users won't need to change alot of thing. I think it's a good idea @ro0NL. (i'll take care of the comments, I just want to wait a little for others' thoughts).
Sorry, I left one (two) extra comment.