New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PhpUnitBridge] Fixed fatal error in CoverageListener when something goes wrong in Test::setUpBeforeClass #24796

Merged
merged 1 commit into from Nov 3, 2017

Conversation

Projects
None yet
5 participants
@lyrixx
Member

lyrixx commented Nov 2, 2017

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR
@lyrixx

This comment has been minimized.

Show comment
Hide comment
@lyrixx

lyrixx Nov 2, 2017

Member

Hmm, I tried to add a test but it's not really possible.

Member

lyrixx commented Nov 2, 2017

Hmm, I tried to add a test but it's not really possible.

@xabbuh

This comment has been minimized.

Show comment
Hide comment
@xabbuh

xabbuh Nov 2, 2017

Member

When can it happen that this method does not exist?

Member

xabbuh commented Nov 2, 2017

When can it happen that this method does not exist?

@lyrixx

This comment has been minimized.

Show comment
Hide comment
@lyrixx

lyrixx Nov 2, 2017

Member

Ah yes I removed the test. but it is still in the PR title and commit message ;)
Try to throw an exception in the setUpBeforeClass and you will see.
(Note I did not dig in PHPUnit to find the root cause. I'm not sure I want to :D )

Member

lyrixx commented Nov 2, 2017

Ah yes I removed the test. but it is still in the PR title and commit message ;)
Try to throw an exception in the setUpBeforeClass and you will see.
(Note I did not dig in PHPUnit to find the root cause. I'm not sure I want to :D )

@xabbuh

This comment has been minimized.

Show comment
Hide comment
@xabbuh

xabbuh Nov 2, 2017

Member

Could it be related to $test being an instance of TestSuite but not TestCase?

Member

xabbuh commented Nov 2, 2017

Could it be related to $test being an instance of TestSuite but not TestCase?

@lyrixx

This comment has been minimized.

Show comment
Hide comment
@lyrixx

lyrixx Nov 2, 2017

Member

I don't know. What do you have in mind ?

Member

lyrixx commented Nov 2, 2017

I don't know. What do you have in mind ?

@xabbuh

This comment has been minimized.

Show comment
Hide comment
@xabbuh

xabbuh Nov 2, 2017

Member

We could then use instanceof instead.

Member

xabbuh commented Nov 2, 2017

We could then use instanceof instead.

@lyrixx

This comment has been minimized.

Show comment
Hide comment
@lyrixx

lyrixx Nov 2, 2017

Member

I was pretty sure you are going to say that.
using instanceof will be a bit boring because we manage many PHPUnit version (pear convention vs namespace :/)

Member

lyrixx commented Nov 2, 2017

I was pretty sure you are going to say that.
using instanceof will be a bit boring because we manage many PHPUnit version (pear convention vs namespace :/)

@xabbuh

This comment has been minimized.

Show comment
Hide comment
@xabbuh

xabbuh Nov 2, 2017

Member

There is an alias for the namespaced class in PHPUnit 4.8 and 5.x. :)

Member

xabbuh commented Nov 2, 2017

There is an alias for the namespaced class in PHPUnit 4.8 and 5.x. :)

@lyrixx

This comment has been minimized.

Show comment
Hide comment
@lyrixx

lyrixx Nov 3, 2017

Member

@xabbuh It should be ok

Member

lyrixx commented Nov 3, 2017

@xabbuh It should be ok

@xabbuh

xabbuh approved these changes Nov 3, 2017

@fabpot

fabpot approved these changes Nov 3, 2017

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Nov 3, 2017

Member

Thank you @lyrixx.

Member

fabpot commented Nov 3, 2017

Thank you @lyrixx.

@fabpot fabpot merged commit 25e0117 into symfony:3.4 Nov 3, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Nov 3, 2017

bug #24796 [PhpUnitBridge] Fixed fatal error in CoverageListener when…
… something goes wrong in Test::setUpBeforeClass (lyrixx)

This PR was merged into the 3.4 branch.

Discussion
----------

[PhpUnitBridge] Fixed fatal error in CoverageListener when something goes wrong in Test::setUpBeforeClass

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

25e0117 [PhpUnitBridge] Fixed fatal error in CoverageListener when something goes wrong in Test::setUpBeforeClass

@lyrixx lyrixx deleted the lyrixx:phpunit branch Nov 3, 2017

This was referenced Nov 5, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment