New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micro optim using explicit root namespaces #24866

Merged
merged 1 commit into from Nov 8, 2017

Conversation

Projects
None yet
9 participants
@nicolas-grekas
Member

nicolas-grekas commented Nov 7, 2017

Q A
Branch? 3.4
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Just doing that makes my local hello world as fast on 3.3 as on 4.0.
Spotted using Blackfire to identify the hot path.
Confirmed using both ab and blackfire curl on a local php -S.

It's not the first time these root namespaces make a measurable difference (on a selected list of functions only, see FriendsOfPHP/PHP-CS-Fixer#3048.)

FriendsOfPHP/PHP-CS-Fixer#3222 might become a more generic fix for this kind of optims.

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Nov 7, 2017

@SpacePossum

This comment has been minimized.

Show comment
Hide comment
@SpacePossum

SpacePossum Nov 7, 2017

Contributor

lets do them all in one go;
#24344 (using FriendsOfPHP/PHP-CS-Fixer#3223)

^_^

Contributor

SpacePossum commented Nov 7, 2017

lets do them all in one go;
#24344 (using FriendsOfPHP/PHP-CS-Fixer#3223)

^_^

@fabpot

fabpot approved these changes Nov 7, 2017

@dunglas

dunglas approved these changes Nov 7, 2017

@xabbuh

xabbuh approved these changes Nov 8, 2017

@nicolas-grekas nicolas-grekas merged commit e78d1c4 into symfony:3.4 Nov 8, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Nov 8, 2017

minor #24866 Micro optim using explicit root namespaces (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

Micro optim using explicit root namespaces

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Just doing that makes my local hello world as fast on 3.3 as on 4.0.
Spotted using Blackfire to identify the hot path.
Confirmed using both `ab` and `blackfire curl` on a local `php -S`.

It's not the first time these root namespaces make a measurable difference (on a selected list of functions only, see FriendsOfPHP/PHP-CS-Fixer#3048.)

FriendsOfPHP/PHP-CS-Fixer#3222 might become a more generic fix for this kind of optims.

Commits
-------

e78d1c4 Micro optim using explicit root namespaces

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:lazy-load branch Nov 9, 2017

@bradjones1

This comment has been minimized.

Show comment
Hide comment
@bradjones1

bradjones1 commented Apr 12, 2018

Follow-up proposal on Drupal core: https://www.drupal.org/project/drupal/issues/2960522

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment