New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Fix dumping with custom base class #24954

Merged
merged 1 commit into from Nov 13, 2017

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Member

nicolas-grekas commented Nov 13, 2017

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #24948
License MIT
Doc PR -

ping @kbond please confirm it's OK for you

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Nov 13, 2017

@nicolas-grekas nicolas-grekas changed the base branch from 3.4 to 3.3 Nov 13, 2017

@kbond

This comment has been minimized.

Show comment
Hide comment
@kbond

kbond Nov 13, 2017

Contributor

This works when I have a custom container base class but it broke the container without a custom base class:

class ApplicationDevDebugProjectContainer extends \Container

Container should not have the \.

Contributor

kbond commented Nov 13, 2017

This works when I have a custom container base class but it broke the container without a custom base class:

class ApplicationDevDebugProjectContainer extends \Container

Container should not have the \.

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas Nov 13, 2017

Member

@kbond thanks, should be fixed.

Member

nicolas-grekas commented Nov 13, 2017

@kbond thanks, should be fixed.

@nicolas-grekas nicolas-grekas merged commit 2dd74ab into symfony:3.3 Nov 13, 2017

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Nov 13, 2017

bug #24954 [DI] Fix dumping with custom base class (nicolas-grekas)
This PR was merged into the 3.3 branch.

Discussion
----------

[DI] Fix dumping with custom base class

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24948
| License       | MIT
| Doc PR        | -

ping @kbond please confirm it's OK for you

Commits
-------

2dd74ab [DI] Fix dumping with custom base class

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:di-root-ns branch Nov 13, 2017

@kbond

This comment has been minimized.

Show comment
Hide comment
@kbond

kbond Nov 13, 2017

Contributor

👍 perfect!

Contributor

kbond commented Nov 13, 2017

👍 perfect!

@fabpot fabpot referenced this pull request Nov 13, 2017

Merged

Release v3.3.12 #24958

This was referenced Nov 21, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment