New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pr/workflow name as graph label #25148

Closed
wants to merge 8 commits into
base: master
from

Conversation

Projects
None yet
7 participants
@shdev
Contributor

shdev commented Nov 24, 2017

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

This pull request added an option to the workflow dumper command, which allows you to add a graph label with the workflow name to the output. Without the option nothing changed the behavior from before.

Example call:

bin/console workflow:dump <workflowname> --label=custom_label
@@ -37,6 +37,7 @@ protected function configure()
->setDefinition(array(
new InputArgument('name', InputArgument::REQUIRED, 'A workflow name'),
new InputArgument('marking', InputArgument::IS_ARRAY, 'A marking (a list of places)'),
new InputOption('workflow-name-label', null, null, 'Labels graph with workflow name'),

This comment has been minimized.

@ro0NL

ro0NL Nov 26, 2017

Contributor

what about --label | --label="value" api? Using workflow name as default value.

This comment has been minimized.

@shdev

shdev Nov 27, 2017

Contributor

Thx for your comment thats a very good idea. I will change it.

This comment has been minimized.

@shdev

shdev Dec 6, 2017

Contributor

I updated my pull request now it's like you suggested

@fabpot

fabpot approved these changes Dec 11, 2017

@Simperfit

This comment has been minimized.

Contributor

Simperfit commented Dec 11, 2017

Could you please rebase to fix the conflict ?

$options = array();
$label = $input->getOption('label');
if (null !== $label && '' !== trim($label)) {
$options = array('graph' => array('label' => $input->getOption('label')));

This comment has been minimized.

@Simperfit

Simperfit Dec 11, 2017

Contributor

You should be using $label instead of $input->getOption('label').

This comment has been minimized.

@shdev

shdev Dec 11, 2017

Contributor

thx, it's done

@fabpot

This comment has been minimized.

Member

fabpot commented Dec 11, 2017

@shdev Can you rebase the pull request? You've merged master, but we don't merge pull requests with merge commits. I can help you do that if needed. Thanks.

@shdev

This comment has been minimized.

Contributor

shdev commented Dec 11, 2017

@fabpot Thx. It would be nice, if you give me some hints to do the rebase. Sorry for the merges, I did the changes on Github.com and I'm not familiar with rebasing there

@fabpot

This comment has been minimized.

Member

fabpot commented Dec 11, 2017

I don't think it's possible to rebase from the UI. I see that you did everything with the web UI, so I've just done the rebase for you. I've downloaded your code and did a git rebase origin/master. Then, I fixed the conflicts for each commit (git rebase --continue when done), and that removed the merge commits.

@shdev

This comment has been minimized.

Contributor

shdev commented Dec 11, 2017

Thank you @fabpot for the work, next time I use rebase

@fabpot

fabpot approved these changes Dec 11, 2017

@fabpot

This comment has been minimized.

Member

fabpot commented Dec 11, 2017

Thank you @shdev.

@fabpot fabpot closed this Dec 11, 2017

fabpot added a commit that referenced this pull request Dec 11, 2017

feature #25148 Pr/workflow name as graph label (shdev)
This PR was squashed before being merged into the 4.1-dev branch (closes #25148).

Discussion
----------

Pr/workflow name as graph label

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

This pull request added an option to the workflow dumper command, which allows you to add a graph label with the workflow name to the output. Without the option nothing changed the behavior from before.

Example call:

```bash
bin/console workflow:dump <workflowname> --label=custom_label
```

Commits
-------

0afce8d Pr/workflow name as graph label

@fabpot fabpot referenced this pull request May 7, 2018

Merged

Release v4.1.0-BETA1 #27181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment