Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpKernel] Read $_ENV when checking SHELL_VERBOSITY #25162

Merged
merged 1 commit into from Nov 26, 2017

Conversation

@nicolas-grekas
Copy link
Member

commented Nov 26, 2017

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Needed so that we can set the env var from phpunit.xml.dist.

@fabpot
fabpot approved these changes Nov 26, 2017
@fabpot

This comment has been minimized.

Copy link
Member

commented Nov 26, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 7de1af4 into symfony:3.4 Nov 26, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build could not complete due to an error
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details
fabpot added a commit that referenced this pull request Nov 26, 2017
bug #25162 [HttpKernel] Read $_ENV when checking SHELL_VERBOSITY (nic…
…olas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[HttpKernel] Read $_ENV when checking SHELL_VERBOSITY

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Needed so that we can set the env var from `phpunit.xml.dist`.

Commits
-------

7de1af4 [HttpKernel] Read $_ENV when checking SHELL_VERBOSITY
nicolas-grekas added a commit that referenced this pull request Nov 27, 2017
minor #25168 [HttpKernel] don't override existing verbosity env var (…
…xabbuh)

This PR was merged into the 3.4 branch.

Discussion
----------

[HttpKernel] don't override existing verbosity env var

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

While playing with the changes from #25162 I noticed that setting the `SHELL_VERBOSITY` env var in `phpunit.xml.dist` did not work as the kernel was setting the variable before the logic in the `Logger` class was executed.

Commits
-------

df4d6d6 don't override existing verbosity env var

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:shell-verb-env branch Nov 29, 2017

This was referenced Nov 30, 2017
@alexislefebvre

This comment has been minimized.

Copy link
Contributor

commented Dec 7, 2017

For future reference, it's related to #24425.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.