Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle][Serializer] Remove YamlEncoder definition if Yaml component isn't installed #25179

Merged
merged 1 commit into from Nov 27, 2017

Conversation

@ogizanagi
Copy link
Member

@ogizanagi ogizanagi commented Nov 27, 2017

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #24634 (comment)
License MIT
Doc PR N/A

Do we need a "symfony/yaml": "<3.2" conflict here (the version used in require-dev)? Otherwise I'll re-introduce the !defined('Symfony\Component\Yaml\Yaml::DUMP_OBJECT') check instead.

xabbuh
xabbuh approved these changes Nov 27, 2017
fabpot
fabpot approved these changes Nov 27, 2017
@fabpot
Copy link
Member

@fabpot fabpot commented Nov 27, 2017

Thank you @ogizanagi.

Loading

@fabpot fabpot merged commit a44f8a5 into symfony:3.3 Nov 27, 2017
3 checks passed
Loading
fabpot added a commit that referenced this issue Nov 27, 2017
…n if Yaml component isn't installed (ogizanagi)

This PR was merged into the 3.3 branch.

Discussion
----------

[FrameworkBundle][Serializer] Remove YamlEncoder definition if Yaml component isn't installed

| Q             | A
| ------------- | ---
| Branch?       | 3.3 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | #24634 (comment) <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Do we need a `"symfony/yaml": "<3.2"` conflict here (the version used in `require-dev`)? Otherwise I'll re-introduce the `!defined('Symfony\Component\Yaml\Yaml::DUMP_OBJECT')` check instead.

Commits
-------

a44f8a5 [FrameworkBundle][Serializer] Remove YamlEncoder definition if Yaml component isn't installed
@ogizanagi ogizanagi deleted the fix/3.3/fwb_serializer_yaml_encoder branch Nov 27, 2017
@fabpot fabpot mentioned this pull request Nov 30, 2017
@fabpot fabpot mentioned this pull request Nov 30, 2017
@fabpot fabpot mentioned this pull request Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants