Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpKernel] Arrays with scalar values passed to ESI fragment renderer throw deprecation notice #25200

Conversation

@Simperfit
Copy link
Contributor

commented Nov 29, 2017

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #25191
License MIT
Doc PR none

Coding in the train to Paris !

img_2832

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Nov 29, 2017

to be rebased on 3.3

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Nov 29, 2017

@Simperfit Simperfit changed the base branch from 3.1 to 3.3 Nov 29, 2017

@Simperfit Simperfit force-pushed the Simperfit:bugfix/array-passed-to-esi-should-not-trigger-deprecation branch from c34abc0 to d84b47f Nov 29, 2017

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Nov 30, 2017

Thank you @Simperfit.

@nicolas-grekas nicolas-grekas merged commit d84b47f into symfony:3.3 Nov 30, 2017

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
nicolas-grekas added a commit that referenced this pull request Nov 30, 2017
bug #25200 [HttpKernel] Arrays with scalar values passed to ESI fragm…
…ent renderer throw deprecation notice (Simperfit)

This PR was merged into the 3.3 branch.

Discussion
----------

[HttpKernel] Arrays with scalar values passed to ESI fragment renderer throw deprecation notice

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | #25191
| License       | MIT
| Doc PR        | none

Coding in the train to Paris !

![img_2832](https://user-images.githubusercontent.com/3451634/33361971-8aa17a70-d4da-11e7-90a0-b2f08a60d0e6.JPG)

Commits
-------

d84b47f [HttpKernel] Arrays with scalar values passed to ESI fragment renderer throw deprecation notice
This was referenced Nov 30, 2017

@sroze sroze deleted the Simperfit:bugfix/array-passed-to-esi-should-not-trigger-deprecation branch Nov 30, 2017

@fabpot fabpot referenced this pull request Dec 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.