Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dotenv] Changed preg_match flags from null to 0 #25217

Merged
merged 1 commit into from Nov 30, 2017

Conversation

@deekthesqueak
Copy link
Contributor

commented Nov 30, 2017

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

I came across this bug while using HHVM in PHP7 mode. The flag should be changed to match type in function signature and bring it in line with other uses of preg_match (https://github.com/symfony/dotenv/blob/3.3/Dotenv.php#L149)

Applicable to 3.3, 3.4, 4.0

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Nov 30, 2017

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Nov 30, 2017

Thank you @deekthesqueak.

@nicolas-grekas nicolas-grekas merged commit b0d297b into symfony:3.3 Nov 30, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details
nicolas-grekas added a commit that referenced this pull request Nov 30, 2017
bug #25217 [Dotenv] Changed preg_match flags from null to 0 (deekthes…
…queak)

This PR was merged into the 3.3 branch.

Discussion
----------

[Dotenv] Changed preg_match flags from null to 0

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

I came across this bug while using HHVM in PHP7 mode. The flag should be changed to match type in function signature and bring it in line with other uses of [preg_match](https://secure.php.net/manual/en/function.preg-match.php) (https://github.com/symfony/dotenv/blob/3.3/Dotenv.php#L149)

Applicable to 3.3, 3.4, 4.0

Commits
-------

b0d297b [Dotenv] Changed preg_match flags from null to 0

@deekthesqueak deekthesqueak deleted the deekthesqueak:DotenvPregMatch branch Nov 30, 2017

This was referenced Nov 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.