New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a more specific file for detecting the bridge #25230

Merged
merged 1 commit into from Dec 1, 2017

Conversation

Projects
None yet
3 participants
@greg0ire
Contributor

greg0ire commented Nov 30, 2017

Q A
Branch? 3.4 because this patch cannot apply before
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #25228
License MIT
Doc PR n/a
Use a more specific file for detecting the bridge
When using bin as a Composer bin-dir, this will break because both
composer.json and bin/simple-phpunit will exist relatively to the
current directory. This change checks for a non-binary file specific to
the bridge that will not have this issue.
Fixes #25228

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Dec 1, 2017

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas
Member

nicolas-grekas commented Dec 1, 2017

Thank you @greg0ire.

@nicolas-grekas nicolas-grekas merged commit 355bbd1 into symfony:3.4 Dec 1, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Dec 1, 2017

bug #25230 Use a more specific file for detecting the bridge (greg0ire)
This PR was merged into the 3.4 branch.

Discussion
----------

Use a more specific file for detecting the bridge

| Q             | A
| ------------- | ---
| Branch?       | 3.4 because this patch cannot apply before
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #25228
| License       | MIT
| Doc PR        | n/a

Commits
-------

355bbd1 Use a more specific file for detecting the bridge

@greg0ire greg0ire deleted the greg0ire:more_accurate_bridge_check branch Dec 1, 2017

This was referenced Dec 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment