New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebProfilerBundle] [TwigBundle] Fix Profiler breaking XHTML pages #25232

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
5 participants
@tistre
Contributor

tistre commented Nov 30, 2017

Q A
Branch? master
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Just a tiny fix: Stop the Profiler from breaking XHTML pages (served with "Content-Type: application/xhtml+xml") - with the added quotes around the nonce attribute value, the page remains well-formed XML.

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas Dec 1, 2017

Member

Would be OK as bug fix on 3.3 also.

Member

nicolas-grekas commented Dec 1, 2017

Would be OK as bug fix on 3.3 also.

@nicolas-grekas nicolas-grekas added this to the 3.3 milestone Dec 1, 2017

@stof

stof approved these changes Dec 1, 2017

@javiereguiluz

This comment has been minimized.

Show comment
Hide comment
@javiereguiluz

javiereguiluz Dec 1, 2017

Member

@tistre thanks for fixing this issue. Could you please rebase it to 3.3 to merge it as a bug fix instead of a new feature? Thanks!

Member

javiereguiluz commented Dec 1, 2017

@tistre thanks for fixing this issue. Could you please rebase it to 3.3 to merge it as a bug fix instead of a new feature? Thanks!

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas Dec 1, 2017

Member

Thank you @tistre.

Member

nicolas-grekas commented Dec 1, 2017

Thank you @tistre.

nicolas-grekas added a commit that referenced this pull request Dec 1, 2017

bug #25232 [WebProfilerBundle] [TwigBundle] Fix Profiler breaking XHT…
…ML pages (tistre)

This PR was submitted for the master branch but it was merged into the 3.3 branch instead (closes #25232).

Discussion
----------

[WebProfilerBundle] [TwigBundle] Fix Profiler breaking XHTML pages

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Just a tiny fix: Stop the Profiler from breaking XHTML pages (served with "Content-Type: application/xhtml+xml") - with the added quotes around the nonce attribute value, the page remains well-formed XML.

Commits
-------

b1ab7d0 [WebProfilerBundle], [TwigBundle] Fix Profiler breaking XHTML pages (Content-Type: application/xhtml+xml)
@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas Dec 1, 2017

Member

I fact it applied cleanly on 3.3, so it's merged now.

Member

nicolas-grekas commented Dec 1, 2017

I fact it applied cleanly on 3.3, so it's merged now.

@tistre tistre deleted the tistre:xhtml_compatible_profiler branch Dec 1, 2017

This was referenced Dec 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment