GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests are red though, and this seems related.
This is for ppl doing that, which is a no-op, but one we catch now:
the added entries are the same as on 4.0/master: we now list the public-by-private legacy services as removed, even if they're not really for BC in 3.4.
won't they appear as removed even if they are not in 4.0?
wdyt? they are in 4.0
definition isn't removed if injected twice or more, is it? If it isn't, wouldn't getRemovedIds() return an id that has not been removed? (I'm wondering why we populate removedIds from another place that the one which actually removes unused definitions)
[DI] Add missing deprecation when fetching private services from Cont…
Thank you @nicolas-grekas.
bug #25244 [DI] Add missing deprecation when fetching private service…
…s from ContainerBuilder (nicolas-grekas)
This PR was merged into the 3.4 branch.
[DI] Add missing deprecation when fetching private services from ContainerBuilder
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #25242
| License | MIT
| Doc PR | -
93c0b38 [DI] Add missing deprecation when fetching private services from ContainerBuilder