New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Trigger deprecation when setting a to-be-private synthetic service #25264

Merged
merged 1 commit into from Dec 2, 2017

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Member

nicolas-grekas commented Dec 1, 2017

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #25253
License MIT
Doc PR -
@fabpot

fabpot approved these changes Dec 2, 2017

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Dec 2, 2017

Member

Thank you @nicolas-grekas.

Member

fabpot commented Dec 2, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 2817576 into symfony:3.4 Dec 2, 2017

1 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

fabpot added a commit that referenced this pull request Dec 2, 2017

bug #25264 [DI] Trigger deprecation when setting a to-be-private synt…
…hetic service (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Trigger deprecation when setting a to-be-private synthetic service

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #25253
| License       | MIT
| Doc PR        | -

Commits
-------

2817576 [DI] Trigger deprecation when setting a to-be-private synthetic service

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:deprec-priv-synth branch Dec 3, 2017

Jean85 added a commit to Jean85/symfony that referenced this pull request Dec 4, 2017

Jean85 added a commit to Jean85/symfony that referenced this pull request Dec 4, 2017

nicolas-grekas added a commit that referenced this pull request Dec 4, 2017

minor #25302 [DependencyInjection] Add tests to #25264 (Jean85)
This PR was merged into the 3.4 branch.

Discussion
----------

[DependencyInjection] Add tests to #25264

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | adds tests for #25264
| License       | MIT

As asked by @nicolas-grekas in #25253 (comment), I've added a test about his PR #25264.

Commits
-------

93441c1 Add test case for #25264

nicolas-grekas added a commit that referenced this pull request Dec 4, 2017

Merge branch '3.4' into 4.0
* 3.4:
  SCA with Php Inspections (EA Extended)
  Add test case for #25264
  Fixed the null value exception case.
  Remove rc/beta suffix from composer.json files
  Throw an exception is expression language is not installed
  Fail as early and noisily as possible
  [Console][DI] Fail gracefully
  [FrameworkBundle] Fix visibility of a test helper
  [link] clear the cache after linking
  [DI] Trigger deprecation when setting a to-be-private synthetic service
  [link] Prevent warnings when running link with 2.7
  [Validator] ExpressionValidator should use OBJECT_TO_STRING to allow value in message
  do not eagerly filter comment lines
  [WebProfilerBundle], [TwigBundle] Fix Profiler breaking XHTML pages (Content-Type: application/xhtml+xml)

nicolas-grekas added a commit that referenced this pull request Dec 4, 2017

Merge branch '4.0'
* 4.0:
  SCA with Php Inspections (EA Extended)
  Add test case for #25264
  Fixed the null value exception case.
  Remove rc/beta suffix from composer.json files
  Ensure services & aliases can be referred to with `__toString`able objects
  Throw an exception is expression language is not installed
  [DI] Cast ids to string, as done on 3.4
  Fail as early and noisily as possible
  [Console][DI] Fail gracefully
  [FrameworkBundle] Fix visibility of a test helper
  [link] clear the cache after linking
  [DI] Trigger deprecation when setting a to-be-private synthetic service
  [Intl] Correct Typehint
  [link] Prevent warnings when running link with 2.7
  [Validator] ExpressionValidator should use OBJECT_TO_STRING to allow value in message
  do not eagerly filter comment lines
  [WebProfilerBundle], [TwigBundle] Fix Profiler breaking XHTML pages (Content-Type: application/xhtml+xml)

chalasr added a commit to chalasr/symfony that referenced this pull request Dec 4, 2017

Merge branch '4.0'
* 4.0: (87 commits)
  [SecurityBundle] fix setLogoutOnUserChange calls for context listeners
  [SecurityBundle] add note to info text of no-op config option logout_on_user_change
  fixed tests
  fixed typo
  [DI] Register singly-implemented interfaces when doing PSR-4 discovery
  [Security] Adding a GuardAuthenticatorHandler alias
  fixed tests
  moved method to function
  marked method as being internal
  [FrameworkBundle] Fix a bug where a color tag will be shown when passing an antislash
  [DI] Fix missing unset leading to false-positive circular ref
  [DI] Fix deep-inlining of non-shared refs
  parse newlines in quoted multiline strings
  Fix collision between view properties and form fields
  Fix collision between view properties and form fields
  Disallow viewing dot-files in Profiler
  [SecurityBundle] Fix compat with HttpFoundation >=3.4
  SCA with Php Inspections (EA Extended)
  Fix for missing whitespace control modifier in form layout
  Add test case for symfony#25264
  ...

This was referenced Dec 4, 2017

ostrolucky pushed a commit to ostrolucky/symfony that referenced this pull request Mar 25, 2018

Merge branch '3.4' into 4.0
* 3.4:
  SCA with Php Inspections (EA Extended)
  Add test case for symfony#25264
  Fixed the null value exception case.
  Remove rc/beta suffix from composer.json files
  Throw an exception is expression language is not installed
  Fail as early and noisily as possible
  [Console][DI] Fail gracefully
  [FrameworkBundle] Fix visibility of a test helper
  [link] clear the cache after linking
  [DI] Trigger deprecation when setting a to-be-private synthetic service
  [link] Prevent warnings when running link with 2.7
  [Validator] ExpressionValidator should use OBJECT_TO_STRING to allow value in message
  do not eagerly filter comment lines
  [WebProfilerBundle], [TwigBundle] Fix Profiler breaking XHTML pages (Content-Type: application/xhtml+xml)

ostrolucky pushed a commit to ostrolucky/symfony that referenced this pull request Mar 25, 2018

Merge branch '4.0'
* 4.0:
  SCA with Php Inspections (EA Extended)
  Add test case for symfony#25264
  Fixed the null value exception case.
  Remove rc/beta suffix from composer.json files
  Ensure services & aliases can be referred to with `__toString`able objects
  Throw an exception is expression language is not installed
  [DI] Cast ids to string, as done on 3.4
  Fail as early and noisily as possible
  [Console][DI] Fail gracefully
  [FrameworkBundle] Fix visibility of a test helper
  [link] clear the cache after linking
  [DI] Trigger deprecation when setting a to-be-private synthetic service
  [Intl] Correct Typehint
  [link] Prevent warnings when running link with 2.7
  [Validator] ExpressionValidator should use OBJECT_TO_STRING to allow value in message
  do not eagerly filter comment lines
  [WebProfilerBundle], [TwigBundle] Fix Profiler breaking XHTML pages (Content-Type: application/xhtml+xml)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment