New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for missing whitespace control modifier in form layout #25278

Merged
merged 1 commit into from Dec 4, 2017

Conversation

Projects
None yet
4 participants
@kubawerlos
Contributor

kubawerlos commented Dec 2, 2017

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #25252
License MIT
Doc PR -

That single missing whitespace control modifier results in e.g. new line in data-prototype attribute when using CollectionType field type in form.

@@ -301,7 +301,7 @@
{% if not child.rendered %}
{{- form_row(child) -}}
{% endif %}
{%- endfor %}
{%- endfor -%}

This comment has been minimized.

@nicolas-grekas

nicolas-grekas Dec 4, 2017

Member

same L318?

@nicolas-grekas

nicolas-grekas Dec 4, 2017

Member

same L318?

This comment has been minimized.

@kubawerlos

kubawerlos Dec 4, 2017

Contributor

of course, done

@kubawerlos

kubawerlos Dec 4, 2017

Contributor

of course, done

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Dec 4, 2017

Member

Thank you @kubawerlos.

Member

fabpot commented Dec 4, 2017

Thank you @kubawerlos.

@fabpot fabpot merged commit 369075a into symfony:2.7 Dec 4, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Dec 4, 2017

bug #25278 Fix for missing whitespace control modifier in form layout…
… (kubawerlos)

This PR was merged into the 2.7 branch.

Discussion
----------

Fix for missing whitespace control modifier in form layout

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #25252
| License       | MIT
| Doc PR        | -

That single missing whitespace control modifier results in e.g. new line in `data-prototype` attribute when using CollectionType field type in form.

Commits
-------

369075a Fix for missing whitespace control modifier in form layout

@kubawerlos kubawerlos deleted the kubawerlos:bugfix/twig-whitespace-control-modifier branch Dec 6, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment