New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Cast ids to string, as done on 3.4 #25284

Merged
merged 2 commits into from Dec 4, 2017

Conversation

Projects
None yet
7 participants
@nicolas-grekas
Member

nicolas-grekas commented Dec 3, 2017

Q A
Branch? 4.0
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

As reported on slack, we're now missing cast-to-string.
This PR puts them explicitly at the places where 3.4 has a call to the removed "normalizeId" method.

2017-12-03 09-25-38

@abellion

This comment has been minimized.

Show comment
Hide comment
@abellion

abellion Dec 3, 2017

Contributor

Why not type hinting the arguments as string ?

Contributor

abellion commented Dec 3, 2017

Why not type hinting the arguments as string ?

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas Dec 3, 2017

Member

Because that'd be a BC break.

Member

nicolas-grekas commented Dec 3, 2017

Because that'd be a BC break.

@dunglas

dunglas approved these changes Dec 3, 2017

@sroze

This comment has been minimized.

Show comment
Hide comment
@sroze

sroze Dec 3, 2017

Member

We definitely need tests for this one.

Member

sroze commented Dec 3, 2017

We definitely need tests for this one.

@ro0NL

ro0NL approved these changes Dec 3, 2017

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas

nicolas-grekas Dec 4, 2017

Member

Thank you @sroze.

Member

nicolas-grekas commented Dec 4, 2017

Thank you @sroze.

@nicolas-grekas nicolas-grekas merged commit 11c6b38 into symfony:4.0 Dec 4, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Dec 4, 2017

bug #25284 [DI] Cast ids to string, as done on 3.4 (nicolas-grekas, s…
…roze)

This PR was merged into the 4.0 branch.

Discussion
----------

[DI] Cast ids to string, as done on 3.4

| Q             | A
| ------------- | ---
| Branch?       | 4.0
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

As reported on slack, we're now missing cast-to-string.
This PR puts them explicitly at the places where 3.4 has a call to the removed "normalizeId" method.

![2017-12-03 09-25-38](https://user-images.githubusercontent.com/243674/33524777-29f5c716-d823-11e7-8ca3-806e83595f5a.png)

Commits
-------

11c6b38 Ensure services & aliases can be referred to with `__toString`able objects
483dd13 [DI] Cast ids to string, as done on 3.4

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:di-cast branch Dec 4, 2017

@fabpot fabpot referenced this pull request Dec 5, 2017

Merged

Release v4.0.1 #25322

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment