New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Routing] Parse PHP constants in YAML routing files #25293

Merged
merged 1 commit into from Dec 4, 2017

Conversation

Projects
None yet
6 participants
@ostrolucky
Contributor

ostrolucky commented Dec 3, 2017

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -
@chalasr

chalasr approved these changes Dec 4, 2017

@xabbuh

xabbuh approved these changes Dec 4, 2017

@fabpot

This comment has been minimized.

Member

fabpot commented Dec 4, 2017

@ostrolucky For next time, having just 1 PR instead of 3 would have been better. First, because all the changes are related, so having one commit with all changes make sense. Then, it's much faster for the core team to process one PR :) Thanks for the contribution.

@fabpot

fabpot approved these changes Dec 4, 2017

@fabpot

This comment has been minimized.

Member

fabpot commented Dec 4, 2017

Thank you @ostrolucky.

@fabpot fabpot merged commit 6040e5f into symfony:master Dec 4, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Dec 4, 2017

feature #25293 [Routing] Parse PHP constants in YAML routing files (o…
…strolucky)

This PR was merged into the 4.1-dev branch.

Discussion
----------

[Routing] Parse PHP constants in YAML routing files

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

6040e5f [Routing] Parse PHP constants in YAML routing files

@fabpot fabpot referenced this pull request May 7, 2018

Merged

Release v4.1.0-BETA1 #27181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment