New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Fix deep-inlining of non-shared refs #25312

Merged
merged 1 commit into from Dec 4, 2017

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Member

nicolas-grekas commented Dec 4, 2017

Q A
Branch? 3.3
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #25263
License MIT
Doc PR -

Non-shared definitions should deep-clone their inlined non-shared definitions.

@fabpot

fabpot approved these changes Dec 4, 2017

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Dec 4, 2017

Member

Thank you @nicolas-grekas.

Member

fabpot commented Dec 4, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit eb2a152 into symfony:3.3 Dec 4, 2017

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Dec 4, 2017

bug #25312 [DI] Fix deep-inlining of non-shared refs (nicolas-grekas)
This PR was merged into the 3.3 branch.

Discussion
----------

[DI] Fix deep-inlining of non-shared refs

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #25263
| License       | MIT
| Doc PR        | -

Non-shared definitions should deep-clone their inlined non-shared definitions.

Commits
-------

eb2a152 [DI] Fix deep-inlining of non-shared refs

@fabpot fabpot referenced this pull request Dec 4, 2017

Merged

Release v3.3.14 #25319

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:di-fix-non-shared-loop branch Dec 4, 2017

This was referenced Dec 4, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment