Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DoctrineBridge] DoctrineDataCollector comments the non runnable part of the query #25346

Conversation

Simperfit
Copy link
Contributor

@Simperfit Simperfit commented Dec 6, 2017

Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #24782
License MIT
Doc PR symfony/symfony-docs#...

img_2932

I think the idea in this ticket is good and it should be implemented. Could we go further by adding more things to this feature, or will it be ok to just comment out the un-needed part to make the kiri
kiri
(french joke for query) runnable ?

@Simperfit
Copy link
Contributor Author

AppVeyor failure is unrelated, do you want me to push force to restart the build ?

@ogizanagi
Copy link
Member

@Simperfit: I've restarted it.

@nicolas-grekas
Copy link
Member

That's a feature, thus for master.

@nicolas-grekas nicolas-grekas added this to the 4.1 milestone Dec 6, 2017
@Simperfit Simperfit force-pushed the bugfix/doctrine-data-collector-the-query-should-be-directly-runnable branch from ffc0b23 to f4998eb Compare December 6, 2017 11:59
@Simperfit Simperfit changed the base branch from 3.3 to master December 6, 2017 11:59
@Simperfit Simperfit force-pushed the bugfix/doctrine-data-collector-the-query-should-be-directly-runnable branch from f4998eb to 42760d0 Compare December 6, 2017 12:00
@Simperfit
Copy link
Contributor Author

done @nicolas-grekas

@Simperfit
Copy link
Contributor Author

travis failure is unrelated

@fabpot
Copy link
Member

fabpot commented Dec 7, 2017

Thank you @Simperfit.

@fabpot fabpot merged commit 42760d0 into symfony:master Dec 7, 2017
fabpot added a commit that referenced this pull request Dec 7, 2017
…n runnable part of the query (Simperfit)

This PR was merged into the 4.1-dev branch.

Discussion
----------

[DoctrineBridge] DoctrineDataCollector comments the non runnable part of the query

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | #24782
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

![img_2932](https://user-images.githubusercontent.com/3451634/33648180-f6c7a5ac-da58-11e7-8bf8-95fc943d16ff.jpeg)

I think the idea in this ticket is good and it should be implemented. Could we go further by adding more things to this feature, or will it be ok to just comment out the un-needed part to make the kiri
![kiri](https://user-images.githubusercontent.com/3451634/33648278-5eccc830-da59-11e7-8034-a1b9efee7673.png)
(french joke for query) runnable ?

Commits
-------

42760d0 [DoctrineBridge] DoctrineDataCollector comments the non runnable part of the query
@fabpot fabpot mentioned this pull request May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants