Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Fix non-string class handling in PhpDumper #25354

Merged
merged 2 commits into from Dec 8, 2017

Conversation

Projects
None yet
4 participants
@nicolas-grekas
Copy link
Member

commented Dec 6, 2017

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #25353
License MIT
Doc PR -
@sroze

This comment has been minimized.

Copy link
Member

commented Dec 6, 2017

Shouldn't we try to stringify instead?

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Dec 6, 2017

The outcome here is a few less classes/files inlined. Not a big deal. Resolving the parameter could led to subtle bugs that are not worth the effort.

@sroze sroze force-pushed the nicolas-grekas:di-fix branch from b2eae06 to 28f0086 Dec 6, 2017

@nicolas-grekas nicolas-grekas added the Ready label Dec 7, 2017

@fabpot

fabpot approved these changes Dec 8, 2017

@fabpot

This comment has been minimized.

Copy link
Member

commented Dec 8, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 28f0086 into symfony:3.4 Dec 8, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Dec 8, 2017

bug #25354 [DI] Fix non-string class handling in PhpDumper (nicolas-g…
…rekas, sroze)

This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Fix non-string class handling in PhpDumper

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #25353
| License       | MIT
| Doc PR        | -

Commits
-------

28f0086 Ensure that inlined services with parameterized class name can be dumped
730b156 [DI] Fix non-string class handling in PhpDumper

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:di-fix branch Dec 8, 2017

This was referenced Dec 15, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.