New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Add atom editor to ide config #25415

Merged
merged 1 commit into from Dec 11, 2017

Conversation

Projects
None yet
4 participants
@lexcast
Contributor

lexcast commented Dec 10, 2017

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Support for uri handler (added here) in Atom editor is still in the current beta version. This works only for windows and mac.

@fabpot

fabpot approved these changes Dec 11, 2017

Great!

@fabpot

This comment has been minimized.

Member

fabpot commented Dec 11, 2017

Thank you @lexcast.

@fabpot fabpot merged commit 191b837 into symfony:master Dec 11, 2017

1 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Dec 11, 2017

feature #25415 [FrameworkBundle] Add atom editor to ide config (lexcast)
This PR was merged into the 4.1-dev branch.

Discussion
----------

[FrameworkBundle] Add atom editor to ide config

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

<!--
- Bug fixes must be submitted against the lowest branch where they apply
  (lowest branches are regularly merged to upper ones so they get the fixes too).
- Features and deprecations must be submitted against the master branch.
- Replace this comment by a description of what your PR is solving.
-->

Support for uri handler (added [here](atom/atom#15935)) in Atom editor is still in the current beta version. This works only for windows and mac.

Commits
-------

191b837 [FrameworkBundle] Add atom editor to ide config

@fabpot fabpot referenced this pull request May 7, 2018

Merged

Release v4.1.0-BETA1 #27181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment