New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] add email_validation_mode option #25478

Merged
merged 1 commit into from Dec 14, 2017

Conversation

Projects
None yet
4 participants
@xabbuh
Member

xabbuh commented Dec 13, 2017

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR
@xabbuh

This comment has been minimized.

Member

xabbuh commented Dec 13, 2017

This makes it possible to configure the default validation mode for the email validator according to the changes made in #24442.

@xabbuh xabbuh force-pushed the xabbuh:pr-24442 branch from e371165 to 3c438bd Dec 13, 2017

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Dec 13, 2017

Cool. Then I propose to patch the recipe for 4.1 and turn html5 on by default there.

@@ -199,6 +199,8 @@
<xsd:attribute name="cache" type="xsd:string" />
<xsd:attribute name="enable-annotations" type="xsd:boolean" />
<xsd:attribute name="static-method" type="xsd:boolean" />
<xsd:attribute name="strict-email" type="xsd:boolean" />

This comment has been minimized.

@xabbuh

xabbuh Dec 13, 2017

Member

This option must also be added in older versions too (see #25480).

@xabbuh xabbuh force-pushed the xabbuh:pr-24442 branch 3 times, most recently from 0247ef0 to 0adec76 Dec 13, 2017

@xabbuh xabbuh force-pushed the xabbuh:pr-24442 branch from 0adec76 to cda5825 Dec 13, 2017

@fabpot

fabpot approved these changes Dec 14, 2017

@fabpot

This comment has been minimized.

Member

fabpot commented Dec 14, 2017

Thank you @xabbuh.

@fabpot fabpot merged commit cda5825 into symfony:master Dec 14, 2017

2 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Dec 14, 2017

feature #25478 [FrameworkBundle] add email_validation_mode option (xa…
…bbuh)

This PR was merged into the 4.1-dev branch.

Discussion
----------

[FrameworkBundle] add email_validation_mode option

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

cda5825 add email_validation_mode option

@xabbuh xabbuh deleted the xabbuh:pr-24442 branch Dec 14, 2017

@fabpot fabpot referenced this pull request May 7, 2018

Merged

Release v4.1.0-BETA1 #27181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment