New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Process] Make `PhpExecutableFinder` look for the `PHP_BINARY` env var #25629

Merged
merged 1 commit into from Dec 31, 2017

Conversation

Projects
None yet
4 participants
@nicolas-grekas
Member

nicolas-grekas commented Dec 29, 2017

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #22101
License MIT
Doc PR -

I think this is enough to fix the linked issue and thus replace #23721.
ping @tomasfejfar FYI

@tomasfejfar

This comment has been minimized.

tomasfejfar commented Dec 29, 2017

This looks great, thanks. Sorry I couldn't find the time to fix it myself.

@fabpot

fabpot approved these changes Dec 31, 2017

@fabpot

This comment has been minimized.

Member

fabpot commented Dec 31, 2017

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 4bd01f2 into symfony:master Dec 31, 2017

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Dec 31, 2017

feature #25629 [Process] Make `PhpExecutableFinder` look for the `PHP…
…_BINARY` env var (nicolas-grekas)

This PR was merged into the 4.1-dev branch.

Discussion
----------

[Process] Make `PhpExecutableFinder` look for the `PHP_BINARY` env var

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22101
| License       | MIT
| Doc PR        | -

I think this is enough to fix the linked issue and thus replace #23721.
ping @tomasfejfar FYI

Commits
-------

4bd01f2 [Process] Make `PhpExecutableFinder` look for the `PHP_BINARY` env var

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:php-bin-opt branch Jan 4, 2018

@fabpot fabpot referenced this pull request May 7, 2018

Merged

Release v4.1.0-BETA1 #27181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment