[Process] Check PHP_BINDIR before $PATH in PhpExecutableFinder #26040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Feb 4, 2018
nicolas-grekas
commented
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #25187 |
| License | MIT |
| Doc PR | - |
fabpot
reviewed
Feb 7, 2018
| @@ -62,6 +62,10 @@ public function find($includeArgs = true) | |||
| } | |||
| } | |||
|
|
|||
| if (is_executable($php = PHP_BINDIR.'/php'.('\\' === DIRECTORY_SEPARATOR ? '.exe' : ''))) { | |||
There was a problem hiding this comment.
This logic does not take into account the PATHEXT env var as done in ExecutableFinder.
There was a problem hiding this comment.
php binaries always are .exe, in php_bindir
fabpot
approved these changes
Feb 12, 2018
|
Thank you @nicolas-grekas. |
fabpot
added a commit
that referenced
this pull request
Feb 12, 2018
…nder (nicolas-grekas) This PR was merged into the 2.7 branch. Discussion ---------- [Process] Check PHP_BINDIR before $PATH in PhpExecutableFinder | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #25187 | License | MIT | Doc PR | - Commits ------- 3a470c4 [Process] Check PHP_BINDIR before $PATH in PhpExecutableFinder
This was referenced Feb 28, 2018
Closed
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.