Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Fix for #2609 #2614

Merged
merged 2 commits into from Nov 11, 2011

Conversation

Projects
None yet
2 participants
Contributor

ondrowan commented Nov 11, 2011

Second take for fix for #2609, hope it's ok now. Tests are failing without my fix and passing with it.

ondrowan added some commits Nov 11, 2011

@ondrowan ondrowan Added check for array fields to be integers in reverseTransform metho…
…d. This prevents checkdate from getting strings as arguments and throwing incorrect ErrorException when submitting form with malformed (string) data in, for example, Date field. #2609
8351a11
@ondrowan ondrowan Added tests for string fix in DateTimeToArrayTransformer (8351a11). 2582fcb

@fabpot fabpot added a commit that referenced this pull request Nov 11, 2011

@fabpot fabpot merged branch ondrowan/2.0 (PR #2614)
Commits
-------

2582fcb Added tests for string fix in DateTimeToArrayTransformer (8351a11).
8351a11 Added check for array fields to be integers in reverseTransform method. This prevents checkdate from getting strings as arguments and throwing incorrect ErrorException when submitting form with malformed (string) data in, for example, Date field. #2609

Discussion
----------

Fix for #2609

Second take for fix for #2609, hope it's ok now. Tests are failing without my fix and passing with it.
7475a39

@fabpot fabpot merged commit 2582fcb into symfony:2.0 Nov 11, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment