New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for name on the unit node #26149

Closed
wants to merge 3 commits into
base: master
from

Conversation

Projects
None yet
5 participants
@Nyholm
Member

Nyholm commented Feb 12, 2018

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #25758
License MIT
Doc PR na

See unit specification and name specification

@chalasr chalasr added the Translator label Feb 12, 2018

@chalasr chalasr added this to the 4.1 milestone Feb 12, 2018

@fabpot

fabpot approved these changes Feb 15, 2018

@fabpot

This comment has been minimized.

Member

fabpot commented Feb 15, 2018

Thank you @Nyholm.

@fabpot fabpot closed this Feb 15, 2018

fabpot added a commit that referenced this pull request Feb 15, 2018

feature #26149 Added support for name on the unit node (Nyholm)
This PR was squashed before being merged into the 4.1-dev branch (closes #26149).

Discussion
----------

Added support for name on the unit node

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #25758
| License       | MIT
| Doc PR        | na

See [unit specification](http://docs.oasis-open.org/xliff/xliff-core/v2.0/os/xliff-core-v2.0-os.html#unit) and [name specification](http://docs.oasis-open.org/xliff/xliff-core/v2.0/os/xliff-core-v2.0-os.html#name)

Commits
-------

30a22aa Added support for name on the unit node
@Nyholm

This comment has been minimized.

Member

Nyholm commented Feb 15, 2018

Thank you for merging

@Nyholm Nyholm deleted the Nyholm:unit-name2 branch Feb 26, 2018

symfony-splitter pushed a commit to symfony/translation that referenced this pull request Mar 30, 2018

bug #26661 [Translation] XLIFF2: Make sure to trim source if it is to…
…o long for "name" (Nyholm)

This PR was merged into the 4.1-dev branch.

Discussion
----------

[Translation] XLIFF2: Make sure to trim source if it is too long for "name"

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

This PR is a follow-up on @javiereguiluz's comment here: symfony/symfony-docs#9302

This feature was introduced in symfony/symfony#26149

Commits
-------

ca41fecfd9 Make sure to trim source if it is too long

fabpot added a commit that referenced this pull request Mar 30, 2018

bug #26661 [Translation] XLIFF2: Make sure to trim source if it is to…
…o long for "name" (Nyholm)

This PR was merged into the 4.1-dev branch.

Discussion
----------

[Translation] XLIFF2: Make sure to trim source if it is too long for "name"

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

This PR is a follow-up on @javiereguiluz's comment here: symfony/symfony-docs#9302

This feature was introduced in #26149

Commits
-------

ca41fec Make sure to trim source if it is too long

@fabpot fabpot referenced this pull request May 7, 2018

Merged

Release v4.1.0-BETA1 #27181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment