New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Workflow] Added a TransitionException #26651

Merged
merged 2 commits into from Mar 23, 2018

Conversation

Projects
None yet
4 participants
@lyrixx
Member

lyrixx commented Mar 23, 2018

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #26587 #26581
License MIT
Doc PR

Note for reviewer: NotEnabledTransitionException and UndefinedTransitionException were not released. So this is not a BC Break.

@lyrixx

This comment has been minimized.

Member

lyrixx commented Mar 23, 2018

Thank you @andrewtch.

@lyrixx lyrixx merged commit 838548c into symfony:master Mar 23, 2018

2 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

lyrixx added a commit that referenced this pull request Mar 23, 2018

feature #26651 [Workflow] Added a TransitionException (andrewtch, lyr…
…ixx)

This PR was merged into the 4.1-dev branch.

Discussion
----------

[Workflow] Added a TransitionException

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #26587 #26581
| License       | MIT
| Doc PR        |

---

Note for reviewer: `NotEnabledTransitionException` and `UndefinedTransitionException` were not released. So this is not a BC Break.

Commits
-------

838548c Finished implementation of TransitionException
9fa4f79 implemented TransitionException to be thrown instead of Logic exception

@lyrixx lyrixx deleted the lyrixx:andrewtch-transition-exception-for-workflow branch Mar 23, 2018

@fabpot fabpot referenced this pull request May 7, 2018

Merged

Release v4.1.0-BETA1 #27181

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment