New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Console] add support for iterable in output #26847

Merged
merged 1 commit into from Apr 7, 2018

Conversation

Projects
None yet
4 participants
@Tobion
Member

Tobion commented Apr 6, 2018

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? not really
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Very useful if you just want to print something from a generator. Using array requires everything in memory. Lets make use of the new iterable type.

@nicolas-grekas nicolas-grekas added this to the 4.1 milestone Apr 7, 2018

@chalasr

chalasr approved these changes Apr 7, 2018

@Tobion Tobion merged commit 5100071 into symfony:master Apr 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

Tobion added a commit that referenced this pull request Apr 7, 2018

feature #26847 [Console] add support for iterable in output (Tobion)
This PR was merged into the 4.1-dev branch.

Discussion
----------

[Console] add support for iterable in output

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | not really
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Very useful if you just want to print something from a generator. Using array requires everything in memory. Lets make use of the new iterable type.

Commits
-------

5100071 [Console] add support for iterable in output

@Tobion Tobion deleted the Tobion:console-output-iterable branch Apr 7, 2018

chalasr added a commit that referenced this pull request Apr 9, 2018

feature #26863 [Console] Support iterable in SymfonyStyle::write/writ…
…eln (ogizanagi)

This PR was merged into the 4.1-dev branch.

Discussion
----------

[Console] Support iterable in SymfonyStyle::write/writeln

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | N/A   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Relates to #26847.

This would enable iterables benefits even when using `SymfonyStyle` output.

Commits
-------

d66827e [Console] Support iterable in SymfonyStyle::write/writeln

@fabpot fabpot referenced this pull request May 7, 2018

Merged

Release v4.1.0-BETA1 #27181

nicolas-grekas added a commit that referenced this pull request Jul 9, 2018

minor #27777 [Console] fix typo in phpdoc (Tobion)
This PR was merged into the 2.8 branch.

Discussion
----------

[Console] fix typo in phpdoc

| Q             | A
| ------------- | ---
| Branch?       | 4.1 (#26847)
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

7aa4557 [Console] fix typo in phpdoc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment