Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Inflector] Support pluralization in the inflector #26890

Merged
merged 1 commit into from Mar 31, 2019

Conversation

Projects
None yet
7 participants
@mbabker
Copy link
Contributor

commented Apr 11, 2018

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? not yet
Fixed tickets N/A
License MIT
Doc PR Not Yet

At present the inflector only supports singularizing plural words, this PR adds the capability to pluralize singular words.

@ostrolucky

This comment has been minimized.

Copy link
Contributor

commented Apr 12, 2018

Have you read readme of this component?

This component is currently marked as internal. Do not use it in your own code.

I don't see this patch utilized in other components, so why adding unused feature into internal component?

@mbabker

This comment has been minimized.

Copy link
Contributor Author

commented Apr 12, 2018

In combination with #26903 this allows us in Joomla to drop our inflector (which is in essence stable but unmaintained because we just don't have the resources to keep up with it) for something which is better maintained.

@fabpot

fabpot approved these changes Mar 31, 2019

@fabpot

This comment has been minimized.

Copy link
Member

commented Mar 31, 2019

Thank you @mbabker.

@fabpot fabpot merged commit 06920a7 into symfony:master Mar 31, 2019

0 of 3 checks passed

continuous-integration/appveyor/pr AppVeyor build failed
Details
continuous-integration/travis-ci/pr The Travis CI build failed
Details
fabbot.io Some changes should be done to comply with our standards.
Details

fabpot added a commit that referenced this pull request Mar 31, 2019

feature #26890 [Inflector] Support pluralization in the inflector (mb…
…abker)

This PR was merged into the 4.3-dev branch.

Discussion
----------

[Inflector] Support pluralization in the inflector

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | not yet
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | Not Yet

At present the inflector only supports singularizing plural words, this PR adds the capability to pluralize singular words.

Commits
-------

06920a7 Support pluralization in the inflector

@mbabker mbabker deleted the mbabker:inflector-pluralization branch Mar 31, 2019

@jewome62

This comment has been minimized.

Copy link
Contributor

commented Apr 1, 2019

After rebase on master, Test suite on Inflector failed :
Exemple : https://travis-ci.org/symfony/symfony/builds/514143324?utm_source=github_status&utm_medium=notification

@nicolas-grekas nicolas-grekas modified the milestones: next, 4.3 Apr 30, 2019

@fabpot fabpot referenced this pull request May 9, 2019

Merged

Release v4.3.0-BETA1 #31435

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.