New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpKernel] Add Kernel::getAnnotatedClassesToCompile() #27168

Merged
merged 1 commit into from May 7, 2018

Conversation

Projects
None yet
4 participants
@nicolas-grekas
Member

nicolas-grekas commented May 5, 2018

Q A
Branch? master
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Now that apps are usually bundle-less, we're missing a way to defined the classes to parse annotations for. Here is a PR fixing this by allowing ppl to define a new getAnnotatedClassesToCompile() on their kernel when needed.

@Tobion

This comment has been minimized.

Member

Tobion commented May 6, 2018

Btw what is the purpose of the annoted class cache?

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented May 6, 2018

The purpose is being able to warmup the annotations' cached reader. Without that, annotations are parsed at runtime the first time

@fabpot

fabpot approved these changes May 7, 2018

@fabpot

This comment has been minimized.

Member

fabpot commented May 7, 2018

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 1d2a49a into symfony:master May 7, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request May 7, 2018

feature #27168 [HttpKernel] Add Kernel::getAnnotatedClassesToCompile(…
…) (nicolas-grekas)

This PR was merged into the 4.1-dev branch.

Discussion
----------

[HttpKernel] Add Kernel::getAnnotatedClassesToCompile()

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Now that apps are usually bundle-less, we're missing a way to defined the classes to parse annotations for. Here is a PR fixing this by allowing ppl to define a new `getAnnotatedClassesToCompile()` on their kernel when needed.

Commits
-------

1d2a49a [HttpKernel] Add Kernel::getAnnotatedClassesToCompile()

@fabpot fabpot referenced this pull request May 7, 2018

Merged

Release v4.1.0-BETA1 #27181

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:kernel-annotated branch May 8, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment