New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Change priority of AddConsoleCommandPass to TYPE_BEFORE_REMOVING #27272

Merged
merged 1 commit into from May 30, 2018

Conversation

Projects
None yet
5 participants
@upyx
Contributor

upyx commented May 15, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #27259
License MIT
Doc PR no

Hello!
There is fix for #27259 issue. It changes priority of AddConsoleCommandPass to TYPE_BEFORE_REMOVING as @chalasr advised. I'm not sure about side effects by that.

@upyx

This comment has been minimized.

Contributor

upyx commented May 15, 2018

Oh... Tests failed in 4.0 branch 😟

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented May 15, 2018

That's for branch 3.4 I suppose, the bug is there also, isn't it?

@upyx upyx changed the base branch from 4.0 to 3.4 May 15, 2018

@chalasr chalasr changed the title from [DI] Change priority of AddConsoleCommandPass to TYPE_BEFORE_REMOVING to [FrameworkBundle] Change priority of AddConsoleCommandPass to TYPE_BEFORE_REMOVING May 15, 2018

@chalasr chalasr added this to the 3.4 milestone May 15, 2018

@upyx

This comment has been minimized.

Contributor

upyx commented May 15, 2018

@chalasr you've renamed PR. Should I change commit description?

@chalasr

This comment has been minimized.

Member

chalasr commented May 16, 2018

@upyx you can, but not a requirement (the rest of the message is precise enough to not care). The reasoning behind the title change is that this change impacts FrameworkBundle only, and we use the title PR as merge commit message.

@upyx

This comment has been minimized.

Contributor

upyx commented May 16, 2018

I've rebased commit on head of 3.4. Tests was broken by merging 2.8 into 3.4.

@fabpot

fabpot approved these changes May 30, 2018

@fabpot

This comment has been minimized.

Member

fabpot commented May 30, 2018

Thank you @upyx.

@fabpot fabpot merged commit e360995 into symfony:3.4 May 30, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request May 30, 2018

bug #27272 [FrameworkBundle] Change priority of AddConsoleCommandPass…
… to TYPE_BEFORE_REMOVING (upyx)

This PR was merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle] Change priority of AddConsoleCommandPass to TYPE_BEFORE_REMOVING

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27259
| License       | MIT
| Doc PR        | no

Hello!
There is fix for #27259 issue. It changes priority of `AddConsoleCommandPass` to `TYPE_BEFORE_REMOVING` as @chalasr advised. I'm not sure about side effects by that.

Commits
-------

e360995 [FrameworkBundle] Change priority of AddConsoleCommandPass to TYPE_BEFORE_REMOVING

This was referenced Jun 25, 2018

leofeyer added a commit to contao/core-bundle that referenced this pull request Jun 26, 2018

Fixed DoctrineMigrationsPass not working with Symfony 3.4.12 anymore …
…(see #1590)

Description
-----------

The changes in symfony/symfony#27272 broke our support for doctrine migrations support.

Commits
-------

5e972d9 Fixed DoctrineMigrationsPass not working with latest Symfony 3.4+ changes anymore

ausi pushed a commit to contao/contao that referenced this pull request Aug 15, 2018

[Core] Fixed DoctrineMigrationsPass not working with Symfony 3.4.12 a…
…nymore (see #1590)

Description
-----------

The changes in symfony/symfony#27272 broke our support for doctrine migrations support.

Commits
-------

5e972d96 Fixed DoctrineMigrationsPass not working with latest Symfony 3.4+ changes anymore

@upyx upyx deleted the upyx:change_add_console_command_pass_priority branch Nov 1, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment