New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to the test container after kernel shutdown #27352

Merged
merged 1 commit into from May 25, 2018

Conversation

Projects
None yet
6 participants
@stof
Member

stof commented May 23, 2018

Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

This reference is not working anymore, as the main container was reset and cleaned. Keeping a reference to the test container will prevent collecting the object graph.

Remove reference to the test container after kernel shutdown
This reference is not working anymore, as the main container was reset and
cleaned. Keeping a reference to the test container will prevent collecting
the object graph.

@nicolas-grekas nicolas-grekas added this to the 4.1 milestone May 23, 2018

@sroze

sroze approved these changes May 23, 2018

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented May 25, 2018

Thank you @stof.

@nicolas-grekas nicolas-grekas merged commit d8fb1b9 into symfony:4.1 May 25, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request May 25, 2018

bug #27352 Remove reference to the test container after kernel shutdo…
…wn (stof)

This PR was merged into the 4.1 branch.

Discussion
----------

Remove reference to the test container after kernel shutdown

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

This reference is not working anymore, as the main container was reset and cleaned. Keeping a reference to the test container will prevent collecting the object graph.

Commits
-------

d8fb1b9 Remove reference to the test container after kernel shutdown

@stof stof deleted the stof:fix_testcase_shutdown branch May 25, 2018

@fabpot fabpot referenced this pull request May 26, 2018

Merged

Release v4.1.0-BETA3 #27390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment