New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] cleanup generated test container #27367

Merged
merged 1 commit into from May 25, 2018

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Member

nicolas-grekas commented May 24, 2018

Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR -

Cleans up removed and hidden services, fixes an issue when the private container locator is inlined.

@nicolas-grekas nicolas-grekas added this to the 4.1 milestone May 24, 2018

@nicolas-grekas nicolas-grekas changed the title from Fwb tune test container to [FrameworkBundle] cleanup generated test container May 24, 2018

@stof

stof approved these changes May 24, 2018

@stof

Actually, can you update tests to cover your changes ?

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented May 24, 2018

Tests fixed.

Status: needs review

@nicolas-grekas nicolas-grekas merged commit d8cbec0 into symfony:4.1 May 25, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request May 25, 2018

bug #27367 [FrameworkBundle] cleanup generated test container (nicola…
…s-grekas)

This PR was merged into the 4.1 branch.

Discussion
----------

[FrameworkBundle] cleanup generated test container

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Cleans up removed and hidden services, fixes an issue when the private container locator is inlined.

Commits
-------

d8cbec0 [FrameworkBundle] cleanup generated test container

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:fwb-tune-test-container branch May 25, 2018

@fabpot fabpot referenced this pull request May 26, 2018

Merged

Release v4.1.0-BETA3 #27390

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment