New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No such return type void #27412

Closed
wants to merge 1 commit into
base: 4.1
from

Conversation

Projects
None yet
3 participants
@philsown

philsown commented May 29, 2018

Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Simply removes the invalid return type "void".

@jvasseur

This comment has been minimized.

Contributor

jvasseur commented May 29, 2018

void is a valid return type for PHP > 7.1 which is required by Symfony 4.0

@philsown

This comment has been minimized.

philsown commented May 29, 2018

Many apologies. I did not see it listed here: http://php.net/manual/en/functions.arguments.php#functions.arguments.type-declaration.types

And indeed, when I flip over to using 7.1, it runs fine. Withdrawn.

@philsown philsown closed this May 29, 2018

@jvasseur

This comment has been minimized.

Contributor

jvasseur commented May 29, 2018

Yeah the void return type seems to be missing from the PHP documentation (the only place I can found it is in the comments of http://php.net/manual/en/functions.returning-values.php).

@philsown

This comment has been minimized.

philsown commented May 29, 2018

No worries. I didn't realize the version requirement myself because I was momentarily running a different PHP CLI version than my server version so composer didn't complain about the version requirement. I'll be more careful submitting these in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment