New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BrowserKit] Fix a BC break in Client affecting Panthère #27485

Merged
merged 1 commit into from Jun 4, 2018

Conversation

Projects
None yet
6 participants
@dunglas
Member

dunglas commented Jun 4, 2018

Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets dunglas/panthere#25
License MIT
Doc PR n/a
@dunglas

This comment has been minimized.

Member

dunglas commented Jun 4, 2018

Fabbot error is a false positive (and not related to this fix).

{
$form->setValues($values);
$serverParameters = 3 === \func_num_args() ? func_get_arg(2) : array();

This comment has been minimized.

@nicolas-grekas

nicolas-grekas Jun 4, 2018

Member

2 < \func_num_args()

@fabpot

fabpot approved these changes Jun 4, 2018

@chalasr

chalasr approved these changes Jun 4, 2018

@xabbuh

xabbuh approved these changes Jun 4, 2018

@fabpot

This comment has been minimized.

Member

fabpot commented Jun 4, 2018

Thank you @dunglas.

@fabpot fabpot merged commit e3aa90f into symfony:4.1 Jun 4, 2018

2 of 3 checks passed

fabbot.io Some changes should be done to comply with our standards.
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

fabpot added a commit that referenced this pull request Jun 4, 2018

bug #27485 [BrowserKit] Fix a BC break in Client affecting Panthère (…
…dunglas)

This PR was squashed before being merged into the 4.1 branch (closes #27485).

Discussion
----------

[BrowserKit] Fix a BC break in Client affecting Panthère

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | dunglas/panthere#25
| License       | MIT
| Doc PR        | n/a

Commits
-------

e3aa90f [BrowserKit] Fix a BC break in Client affecting Panthère

@dunglas dunglas deleted the dunglas:fix-panthere-25 branch Jun 5, 2018

@fabpot fabpot referenced this pull request Jun 25, 2018

Merged

Release v4.1.1 #27706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment