New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DebugBundle] DebugBundle::registerCommands should be noop #27496

Merged
merged 1 commit into from Jun 4, 2018

Conversation

Projects
None yet
5 participants
@ogizanagi
Member

ogizanagi commented Jun 4, 2018

Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #27493
License MIT
Doc PR N/A
@fabpot

fabpot approved these changes Jun 4, 2018

@alcohol

This comment has been minimized.

Contributor

alcohol commented Jun 4, 2018

Can confirm this fixes #27493

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Jun 4, 2018

Thank you @ogizanagi.

@nicolas-grekas nicolas-grekas merged commit dd4b0ed into symfony:4.1 Jun 4, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jun 4, 2018

bug #27496 [DebugBundle] DebugBundle::registerCommands should be noop…
… (ogizanagi)

This PR was merged into the 4.1 branch.

Discussion
----------

[DebugBundle] DebugBundle::registerCommands should be noop

| Q             | A
| ------------- | ---
| Branch?       | 4.1 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #27493   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Commits
-------

dd4b0ed [DebugBundle] DebugBundle::registerCommands should be noop

@ogizanagi ogizanagi deleted the ogizanagi:fix/debug_bundle/noop_register_commands branch Jun 4, 2018

@fabpot fabpot referenced this pull request Jun 25, 2018

Merged

Release v4.1.1 #27706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment