New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Routing] Don't reorder past variable-length placeholders #27498

Merged
merged 2 commits into from Jun 4, 2018

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Member

nicolas-grekas commented Jun 4, 2018

Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? no
Fixed tickets #27491
License MIT
@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Jun 4, 2018

Thank you @nanocom.

@nicolas-grekas nicolas-grekas merged commit 44616d9 into symfony:4.1 Jun 4, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jun 4, 2018

bug #27498 [Routing] Don't reorder past variable-length placeholders …
…(nanocom, nicolas-grekas)

This PR was merged into the 4.1 branch.

Discussion
----------

[Routing] Don't reorder past variable-length placeholders

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| Fixed tickets | #27491
| License       | MIT

Commits
-------

44616d9 [Router] regression when matching a route
7a750d4 [Routing] Don't reorder past variable-length placeholders

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:route-fix branch Jun 4, 2018

@fabpot fabpot referenced this pull request Jun 25, 2018

Merged

Release v4.1.1 #27706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment