New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Debug] Pass previous exception to FatalErrorException #27514

Merged
merged 1 commit into from Jun 6, 2018

Conversation

Projects
None yet
5 participants
@pmontoya
Contributor

pmontoya commented Jun 6, 2018

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #27483
License MIT

Add a previous parameter to FatalErrorException.
Call \ErrorException with this parameter.
Update parent::__constructor for inherited classes with default parameters and the new one

@pmontoya

This comment has been minimized.

Contributor

pmontoya commented Jun 6, 2018

I don't understand the travis error and can't reproduce it. Someone can help me? Thanks

@xabbuh xabbuh added the Debug label Jun 6, 2018

@xabbuh xabbuh added this to the 2.8 milestone Jun 6, 2018

@pmontoya pmontoya changed the title from Pass previous exception to FatalErrorException to [Debug] Pass previous exception to FatalErrorException Jun 6, 2018

@xabbuh

xabbuh approved these changes Jun 6, 2018

@fabpot

fabpot approved these changes Jun 6, 2018

@fabpot

This comment has been minimized.

Member

fabpot commented Jun 6, 2018

Thank you @pmontoya.

@fabpot fabpot merged commit 7f9780b into symfony:2.8 Jun 6, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jun 6, 2018

bug #27514 [Debug] Pass previous exception to FatalErrorException (pm…
…ontoya)

This PR was merged into the 2.8 branch.

Discussion
----------

[Debug] Pass previous exception to FatalErrorException

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27483
| License       | MIT

Add a previous parameter to FatalErrorException.
Call \ErrorException with this parameter.
Update parent::__constructor for inherited classes with default parameters and the new one

Commits
-------

7f9780b Pass previous exception to FatalErrorException
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment