New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "bug #26138 [HttpKernel] Catch HttpExceptions when templating is not installed (cilefen)" #27516

Merged
merged 1 commit into from Jun 6, 2018

Conversation

Projects
None yet
4 participants
@nicolas-grekas
Member

nicolas-grekas commented Jun 6, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #27212
License MIT
Doc PR -

This reverts commit b213c5a, reversing
changes made to 61af0e3.

This breaks BC and is more like a new feature, let's move this on master.

Revert "bug #26138 [HttpKernel] Catch HttpExceptions when templating …
…is not installed (cilefen)"

This reverts commit b213c5a, reversing
changes made to 61af0e3.
@chalasr

This comment has been minimized.

Member

chalasr commented Jun 6, 2018

c93c9a5 will need to be reverted when merging this into 4.1.

@chalasr

chalasr approved these changes Jun 6, 2018

@fabpot

fabpot approved these changes Jun 6, 2018

@nicolas-grekas nicolas-grekas merged commit c6acad7 into symfony:3.4 Jun 6, 2018

2 of 3 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jun 6, 2018

bug #27516 Revert "bug #26138 [HttpKernel] Catch HttpExceptions when …
…templating is not installed (cilefen)" (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

Revert "bug #26138 [HttpKernel] Catch HttpExceptions when templating is not installed (cilefen)"

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27212
| License       | MIT
| Doc PR        | -

This reverts commit b213c5a, reversing
changes made to 61af0e3.

This breaks BC and is more like a new feature, let's move this on master.

Commits
-------

c6acad7 Revert "bug #26138 [HttpKernel] Catch HttpExceptions when templating is not installed (cilefen)"

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:http-x-revert branch Jun 6, 2018

takeit added a commit to takeit/web-publisher that referenced this pull request Jun 12, 2018

takeit added a commit to SuperdeskWebPublisher/SWPBridgeBundle that referenced this pull request Jun 12, 2018

This was referenced Jun 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment