New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] fix for allowing single colon controller notation #27566

Merged
merged 1 commit into from Jun 11, 2018

Conversation

@dmaicher
Contributor

dmaicher commented Jun 9, 2018

Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #27522
License MIT
Doc PR -

This fixes a BC break introduced in #26085 (review).

ping @Tobion

$controller = str_replace(':', '::', $controller);
@trigger_error(sprintf('Referencing controllers with a single colon is deprecated since Symfony 4.1. Use %s instead.', $controller), E_USER_DEPRECATED);
$nonDeprecatedNotation = str_replace(':', '::', $controller);
@trigger_error(sprintf('Referencing controllers with a single colon is deprecated since Symfony 4.1. Use %s instead.', $nonDeprecatedNotation), E_USER_DEPRECATED);

This comment has been minimized.

@chalasr

chalasr Jun 10, 2018

Member

"%s"?

@Tobion

Tobion approved these changes Jun 11, 2018

@fabpot

fabpot approved these changes Jun 11, 2018

@fabpot

This comment has been minimized.

Member

fabpot commented Jun 11, 2018

Thank you @dmaicher.

@fabpot fabpot merged commit 1680674 into symfony:4.1 Jun 11, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jun 11, 2018

bug #27566 [FrameworkBundle] fix for allowing single colon controller…
… notation (dmaicher)

This PR was merged into the 4.1 branch.

Discussion
----------

[FrameworkBundle] fix for allowing single colon controller notation

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27522
| License       | MIT
| Doc PR        | -

This fixes a BC break introduced in #26085 (review).

ping @Tobion

Commits
-------

1680674 [FrameworkBundle] fix for allowing single colon controller notation

@fabpot fabpot referenced this pull request Jun 25, 2018

Merged

Release v4.1.1 #27706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment