New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PhpUnitBridge] Fix error on some Windows OS #27567

Merged
merged 1 commit into from Jun 10, 2018

Conversation

Projects
None yet
4 participants
@Nsbx
Contributor

Nsbx commented Jun 9, 2018

Q A
Branch? master
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #27439
License MIT

Bug Fix on PHPUnit Bridge

@nicolas-grekas nicolas-grekas changed the title from Fix error on some Windows OS to [PhpUnitBridge] Fix error on some Windows OS Jun 9, 2018

@nicolas-grekas

nicolas-grekas approved these changes Jun 9, 2018 edited

certutil is available since Vista and allows downloading.
(For 2.8)

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Jun 9, 2018

@fabpot

fabpot approved these changes Jun 10, 2018

@fabpot fabpot changed the base branch from master to 3.4 Jun 10, 2018

@fabpot

This comment has been minimized.

Member

fabpot commented Jun 10, 2018

Thank you @Nsbx.

@fabpot fabpot merged commit 50979b5 into symfony:3.4 Jun 10, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Jun 10, 2018

bug #27567 [PhpUnitBridge] Fix error on some Windows OS (Nsbx)
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #27567).

Discussion
----------

[PhpUnitBridge] Fix error on some Windows OS

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27439
| License       | MIT

Bug Fix on PHPUnit Bridge

Commits
-------

50979b5 [PhpUnitBridge] Fix error on some Windows OS

This was referenced Jun 25, 2018

@Nsbx Nsbx deleted the Nsbx:nsbx-fix branch Aug 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment