Join GitHub today
[VarDumper] Fix dumping by splitting Server/Connection out of Dumper/ServerDumper #27614
Right now, the
My bad for not spotting this at the review stage.
This was referenced
Jun 17, 2018
Thanks for giving it a look :)
Well, I don't agree.
To me, the culprit here really is the
So, I tried again keeping
Yes I also struggled with the
Hope you're wrong ^^'
referenced this pull request
Jun 19, 2018
changed the title from
[VarDumper] Replace Dumper/ServerDumper by Server/Connection
[VarDumper] Fix dumping by splitting Server/Connection out of Dumper/ServerDumper
Jun 20, 2018
Tested and code looks good to me, thanks.
However, I encountered an issue that previously didn't exist: at least with php built-in webserver &
bin/console server:run, as soon as the connection is lost (by shutting down the dump server previously up, executing a request and re-uping the server), the server won't get any input as
stream_socket_sendto will throw a "Broken pipe" error.
Steps to reproduce:
- make a request calling
dump(). At this stage, the dump is properly collected by the server.
- Shutdown the server.
- Make the same request again.
- Re-up the server (
bin/console server:dump). Do some more requests. Dumps will never reach the server until you restart the web server.
No, it doesn't work at all now, unless you restore a timeout in
But honestly, if you want to give a try to async with previous version + patch above, I won't personally mind because I didn't reproduced on a different machine but with very similar env. We may reconsider if we have other reports. Or create another PR for async.