New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FrameworkBundle] Ignore keepQueryParams attribute when generating route redirect #27664

Merged
merged 1 commit into from Jun 21, 2018

Conversation

Projects
None yet
3 participants
@vudaltsov
Contributor

vudaltsov commented Jun 20, 2018

Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
License MIT
Doc PR

Prevents keepQueryParams from appearing in query.

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Jun 21, 2018

Thank you @vudaltsov.

@nicolas-grekas nicolas-grekas merged commit 1e10475 into symfony:4.1 Jun 21, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jun 21, 2018

bug #27664 [FrameworkBundle] Ignore keepQueryParams attribute when ge…
…nerating route redirect (vudaltsov)

This PR was merged into the 4.1 branch.

Discussion
----------

[FrameworkBundle] Ignore keepQueryParams attribute when generating route redirect

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Prevents keepQueryParams from appearing in query.

Commits
-------

1e10475 Ignore keepQueryParams attribute when generating route redirect.

@vudaltsov vudaltsov deleted the vudaltsov:ignore-keep-query-attribute branch Jun 21, 2018

@fabpot fabpot referenced this pull request Jun 25, 2018

Merged

Release v4.1.1 #27706

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment