New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DI] Resolve env placeholder in logs #27690

Merged
merged 1 commit into from Jun 24, 2018

Conversation

Projects
None yet
4 participants
@ro0NL
Contributor

ro0NL commented Jun 23, 2018

Q A
Branch? 3.4
Bug fix? yes-ish
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #...
License MIT
Doc PR symfony/symfony-docs#...

Resolve env placeholders in container logs, discovered when using env for e.g. a service class.

# before
Skipping service "some": Class or interface "env_SOME_b9d8c9c955b39aa96bb2be747b23c3cf" cannot be loaded.

# after
Skipping service "some": Class or interface "%env(SOME)%" cannot be loaded.
@nicolas-grekas

Placeholder should never leak.

@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Jun 24, 2018

Thank you @ro0NL.

@nicolas-grekas nicolas-grekas merged commit b58eb01 into symfony:3.4 Jun 24, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jun 24, 2018

bug #27690 [DI] Resolve env placeholder in logs (ro0NL)
This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Resolve env placeholder in logs

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes-ish
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

Resolve env placeholders in container logs, discovered when using env for e.g. a service class.

```
# before
Skipping service "some": Class or interface "env_SOME_b9d8c9c955b39aa96bb2be747b23c3cf" cannot be loaded.

# after
Skipping service "some": Class or interface "%env(SOME)%" cannot be loaded.
```

Commits
-------

b58eb01 [DI] Resolve env placeholder in logs

@ro0NL ro0NL deleted the ro0NL:di/env-logs branch Jun 24, 2018

This was referenced Jun 25, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment