New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SecurityBundle] Dont throw if "security.http_utils" is not found #27701

Merged
merged 1 commit into from Jun 25, 2018

Conversation

Projects
None yet
4 participants
@nicolas-grekas
Member

nicolas-grekas commented Jun 25, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #27445
License MIT
Doc PR -

The comment + test were misleading, the actual important thing is wiring AddSessionDomainConstraintPass before removing passes, which is already the case already.

@stof

stof approved these changes Jun 25, 2018

@nicolas-grekas nicolas-grekas merged commit db88330 into symfony:3.4 Jun 25, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jun 25, 2018

bug #27701 [SecurityBundle] Dont throw if "security.http_utils" is no…
…t found (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[SecurityBundle] Dont throw if "security.http_utils" is not found

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27445
| License       | MIT
| Doc PR        | -

The comment + test were misleading, the actual important thing is wiring `AddSessionDomainConstraintPass` before removing passes, which is already the case already.

Commits
-------

db88330 [SecurityBundle] Dont throw if "security.http_utils" is not found

@fabpot fabpot referenced this pull request Jun 25, 2018

Merged

Release v3.4.12 #27704

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:sec-fix branch Jun 25, 2018

This was referenced Jun 25, 2018

@alexislefebvre

This comment has been minimized.

Contributor

alexislefebvre commented Jun 29, 2018

It looks like it reverts c003b7a, but this PR targets Symfony 3.4, while c003b7a targeted 2.7. Should it be backported to Symfony 2.7 and/or 2.8?

I had the same bug when launching tests that worked 5 months ago : https://travis-ci.org/alexislefebvre/AsyncTweetsBundle/builds/398227684 is broken but the same commit tested 5 months ago didn't crash: https://travis-ci.org/alexislefebvre/AsyncTweetsBundle/builds/339996354

nicolas-grekas added a commit that referenced this pull request Jun 29, 2018

bug #27701 [SecurityBundle] Dont throw if "security.http_utils" is no…
…t found (nicolas-grekas)

This PR was merged into the 3.4 branch.

Discussion
----------

[SecurityBundle] Dont throw if "security.http_utils" is not found

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #27445
| License       | MIT
| Doc PR        | -

The comment + test were misleading, the actual important thing is wiring `AddSessionDomainConstraintPass` before removing passes, which is already the case already.

Commits
-------

db88330 [SecurityBundle] Dont throw if "security.http_utils" is not found
@nicolas-grekas

This comment has been minimized.

Member

nicolas-grekas commented Jun 29, 2018

@alexislefebvre you're right! 2.7 is out of maintenance, so here is the cherry-pick on 2.8: 6e5c15d

@alexislefebvre

This comment has been minimized.

Contributor

alexislefebvre commented Jun 29, 2018

You were fast, thanks @nicolas-grekas :)

nicolas-grekas added a commit that referenced this pull request Jun 29, 2018

Merge branch '2.8' into 3.4
* 2.8:
  [HttpFoundation] update phpdoc of FlashBagInterface::add()
  bug #27701 [SecurityBundle] Dont throw if "security.http_utils" is not found (nicolas-grekas)
  [Validator] Fix the namespace of RegexTest

nicolas-grekas added a commit that referenced this pull request Jun 29, 2018

Merge branch '3.4' into 4.0
* 3.4:
  [HttpFoundation] update phpdoc of FlashBagInterface::add()
  [ProxyManagerBridge] Fix support of private services (bis)
  bug #27701 [SecurityBundle] Dont throw if "security.http_utils" is not found (nicolas-grekas)
  [Form] relax fixtures for forward compat
  [Validator] Fix the namespace of RegexTest
  [Lock] fix locale dependent test case

nicolas-grekas added a commit that referenced this pull request Jun 29, 2018

Merge branch '4.0' into 4.1
* 4.0:
  [HttpFoundation] update phpdoc of FlashBagInterface::add()
  [ProxyManagerBridge] Fix support of private services (bis)
  bug #27701 [SecurityBundle] Dont throw if "security.http_utils" is not found (nicolas-grekas)
  [Form] relax fixtures for forward compat
  [Validator] Fix the namespace of RegexTest
  [Lock] fix locale dependent test case

nicolas-grekas added a commit to nicolas-grekas/symfony that referenced this pull request Jun 29, 2018

Merge branch '4.1'
* 4.1:
  [HttpFoundation] update phpdoc of FlashBagInterface::add()
  [ProxyManagerBridge] Fix support of private services (bis)
  bug symfony#27701 [SecurityBundle] Dont throw if "security.http_utils" is not found (nicolas-grekas)
  [Form] relax fixtures for forward compat
  [Validator] Fix the namespace of RegexTest
  [Lock] fix locale dependent test case
@alexislefebvre

This comment has been minimized.

Contributor

alexislefebvre commented Jul 2, 2018

Is a new release of 2.8 scheduled? The last version doesn't contain this change.

@alexislefebvre

This comment has been minimized.

Contributor

alexislefebvre commented Jul 9, 2018

@fabpot Could you please publish a new 2.8 release? The last build 2.8.42 is broken, the fix in 6e5c15d is merged in 2.8 but is not released yet, it will solve this problem. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment