Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpKernel] Fixes invalid REMOTE_ADDR in inline subrequest when configuring trusted proxy with subnet #28003

Merged
merged 1 commit into from Jul 31, 2018

Conversation

Projects
None yet
3 participants
@netiul
Copy link
Contributor

commented Jul 19, 2018

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28000
License MIT
Doc PR n/a

When trusted proxies are configured including a subnet a subrequest initiated by the InlineFragmentRenderer would contain an invalid REMOTE_ADDR server variable.

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Jul 23, 2018

AFAIK, subnets have never been supported, isn't it? If confirmed, shouldn't this be a new feature, thus on master?

@netiul

This comment has been minimized.

Copy link
Contributor Author

commented Jul 23, 2018

@nicolas-grekas https://symfony.com/doc/current/deployment/proxies.html. Feature is there for quite some time actually.

@nicolas-grekas nicolas-grekas added this to the 2.8 milestone Jul 23, 2018

@nicolas-grekas nicolas-grekas requested review from nicolas-grekas and stof Jul 29, 2018

@nicolas-grekas nicolas-grekas force-pushed the netiul:ticket_28000 branch from 70c2c1a to f82ff70 Jul 31, 2018

@nicolas-grekas nicolas-grekas force-pushed the netiul:ticket_28000 branch from f82ff70 to f657dd2 Jul 31, 2018

@nicolas-grekas
Copy link
Member

left a comment

(just pushed minor CS changes)

@nicolas-grekas

This comment has been minimized.

Copy link
Member

commented Jul 31, 2018

Thank you @netiul.

@nicolas-grekas nicolas-grekas merged commit f657dd2 into symfony:2.8 Jul 31, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Jul 31, 2018

bug #28003 [HttpKernel] Fixes invalid REMOTE_ADDR in inline subreques…
…t when configuring trusted proxy with subnet (netiul)

This PR was merged into the 2.8 branch.

Discussion
----------

[HttpKernel] Fixes invalid REMOTE_ADDR in inline subrequest when configuring trusted proxy with subnet

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28000    <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | n/a

When trusted proxies are configured including a subnet a subrequest initiated by the InlineFragmentRenderer would contain an invalid REMOTE_ADDR server variable.

Commits
-------

f657dd2 [HttpKernel] Fixed invalid REMOTE_ADDR in inline subrequest when configuring trusted proxy with subnet
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.