Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Messenger] Fix error message on undefined message class for non-subscriber handler #28059

Merged
merged 1 commit into from Jul 26, 2018

Conversation

Projects
None yet
4 participants
@chalasr
Copy link
Member

commented Jul 25, 2018

Q A
Branch? 4.1
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR n/a

Fixes a wrong hint talking about getHandledMessages() while the handler does not implement MessageSubscriberInterface.

@chalasr chalasr added this to the 4.1 milestone Jul 25, 2018

@chalasr chalasr force-pushed the chalasr:msg-fix-error branch from e6842ea to e5ea3bc Jul 25, 2018

@chalasr chalasr requested review from ogizanagi and sroze and removed request for ogizanagi Jul 26, 2018

@ogizanagi
Copy link
Member

left a comment

Good catch

@sroze

sroze approved these changes Jul 26, 2018

@sroze

This comment has been minimized.

Copy link
Member

commented Jul 26, 2018

Good catch, thanks @chalasr.

@sroze sroze merged commit e5ea3bc into symfony:4.1 Jul 26, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

sroze added a commit that referenced this pull request Jul 26, 2018

bug #28059 [Messenger] Fix error message on undefined message class f…
…or non-subscriber handler (chalasr)

This PR was merged into the 4.1 branch.

Discussion
----------

[Messenger] Fix error message on undefined message class for non-subscriber handler

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Fixes a wrong hint talking about `getHandledMessages()` while the handler does not implement `MessageSubscriberInterface`.

Commits
-------

e5ea3bc [Messenger] Fix error message on undefined message class for non-subscriber handler

@chalasr chalasr deleted the chalasr:msg-fix-error branch Jul 26, 2018

@fabpot fabpot referenced this pull request Aug 1, 2018

Merged

Release v4.1.3 #28104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.