New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the Expires header when calling Response::expire() #28083

Merged
merged 1 commit into from Aug 2, 2018

Conversation

Projects
None yet
5 participants
@javiereguiluz
Member

javiereguiluz commented Jul 27, 2018

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #13341
License MIT
Doc PR -
@fabpot

fabpot approved these changes Aug 2, 2018

@fabpot

This comment has been minimized.

Show comment
Hide comment
@fabpot

fabpot Aug 2, 2018

Member

Thank you @javiereguiluz.

Member

fabpot commented Aug 2, 2018

Thank you @javiereguiluz.

@fabpot fabpot merged commit ac0cd15 into symfony:2.8 Aug 2, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

fabpot added a commit that referenced this pull request Aug 2, 2018

bug #28083 Remove the Expires header when calling Response::expire() …
…(javiereguiluz)

This PR was merged into the 2.8 branch.

Discussion
----------

Remove the Expires header when calling Response::expire()

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #13341   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | -

Commits
-------

ac0cd15 Remove the Expires header when calling Response::expire()

This was referenced Aug 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment