Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HttpKernel] fix forwarding trusted headers as server parameters #28241

Merged
merged 1 commit into from Aug 24, 2018

Conversation

Projects
None yet
3 participants
@nicolas-grekas
Copy link
Member

commented Aug 22, 2018

Q A
Branch? 2.8
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28233, #28226, #28225, #28240
License MIT
Doc PR -

@nicolas-grekas nicolas-grekas force-pushed the nicolas-grekas:http-kernel-fix branch from 8e8f09e to 9295348 Aug 22, 2018

@nicolas-grekas nicolas-grekas merged commit 9295348 into symfony:2.8 Aug 24, 2018

3 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Aug 24, 2018

bug #28241 [HttpKernel] fix forwarding trusted headers as server para…
…meters (nicolas-grekas)

This PR was merged into the 2.8 branch.

Discussion
----------

[HttpKernel] fix forwarding trusted headers as server parameters

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28233, #28226, #28225, #28240
| License       | MIT
| Doc PR        | -

Commits
-------

9295348 [HttpKernel] fix forwarding trusted headers as server parameters

@nicolas-grekas nicolas-grekas deleted the nicolas-grekas:http-kernel-fix branch Aug 24, 2018

This was referenced Aug 27, 2018

@vlahanas

This comment has been minimized.

Copy link

commented Aug 30, 2018

When generating a url using UrlGeneratorInterface with reference type UrlGeneratorInterface::ABSOLUTE_URL, it does not maintain https. Instead, it always seems to be using http for the generated url. Any clues on what might be the cause?

@nicolas-grekas

This comment has been minimized.

Copy link
Member Author

commented Aug 30, 2018

Please submit a separate issue and provide a reproducer, that would help a lot (please be sure this issue exists with the latest version before). Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.