New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DoctrineBridge] support __toString as documented for UniqueEntityValidator #28252

Merged
merged 1 commit into from Aug 24, 2018

Conversation

Projects
None yet
4 participants
@dmaicher
Contributor

dmaicher commented Aug 23, 2018

Q A
Branch? 3.4
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets #28245
License MIT
Doc PR -

This fixes #28245.

It brings back handling __toString as documented for invalid values.

@nicolas-grekas nicolas-grekas added this to the 3.4 milestone Aug 24, 2018

@nicolas-grekas

This comment has been minimized.

Show comment
Hide comment
@nicolas-grekas
Member

nicolas-grekas commented Aug 24, 2018

Thank you @dmaicher.

@nicolas-grekas nicolas-grekas merged commit 2ac883a into symfony:3.4 Aug 24, 2018

1 of 3 checks passed

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
fabbot.io Your code looks good.
Details

nicolas-grekas added a commit that referenced this pull request Aug 24, 2018

bug #28252 [DoctrineBridge] support __toString as documented for Uniq…
…ueEntityValidator (dmaicher)

This PR was squashed before being merged into the 3.4 branch (closes #28252).

Discussion
----------

[DoctrineBridge] support __toString as documented for UniqueEntityValidator

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #28245
| License       | MIT
| Doc PR        | -

This fixes #28245.

It brings back handling `__toString` as documented for invalid values.

Commits
-------

2ac883a [DoctrineBridge] support __toString as documented for UniqueEntityValidator

@dmaicher dmaicher deleted the dmaicher:issue-28245 branch Aug 24, 2018

This was referenced Aug 28, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment